Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-5434] feat: split csv aggregate API for some product #464

Merged
merged 12 commits into from
Sep 11, 2024
Merged

Conversation

eugenbegiqi
Copy link
Contributor

List of Changes

Added three APIs and implemented logic to check fields in the CSV.

How Has This Been Tested?

Local Test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Sorry, something went wrong.

@eugenbegiqi eugenbegiqi requested a review from a team as a code owner September 4, 2024 16:43
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be better to add this path inside .gitignore file because it is about eclipse project

@eugenbegiqi eugenbegiqi requested a review from manuraf September 5, 2024 10:28
@manuraf manuraf changed the title [SELC-5434] : split csv aggregate API for some product [SELC-5434] feat: split csv aggregate API for some product Sep 5, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
26.2% Coverage on New Code (required ≥ 80%)
10.8% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@manuraf manuraf merged commit 579d0e7 into main Sep 11, 2024
6 of 9 checks passed
@manuraf manuraf deleted the SELC-5434 branch September 11, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants