Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove InstitutionType from institutionContractMappings on onboarding-sdk #475

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

manuraf
Copy link
Contributor

@manuraf manuraf commented Sep 9, 2024

List of Changes

  • Remove InstitutionType as key from institutionContractMappings
  • Deploy new sdk version 0.2.0
  • Using new sdk version on onboarding-functions

Motivation and Context

This PR fix an issue that happens in prod environment. Product is used by all microservices which serialize a file product.json. If this file contains new InstitutionType and microservices are not using sdk that container this new type they will broke the flow because not recognize new type. Setting key as String avoid this problem.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@manuraf manuraf requested a review from a team as a code owner September 9, 2024 10:34
@github-actions github-actions bot added functions Changes are related to functions onboarding-ms libs hotfix labels Sep 9, 2024
Copy link

sonarqubecloud bot commented Sep 9, 2024

@andrea-putzu andrea-putzu changed the base branch from releases/0.3.4 to main September 9, 2024 10:45
@andrea-putzu andrea-putzu merged commit fe0ec20 into main Sep 9, 2024
3 of 9 checks passed
@andrea-putzu andrea-putzu deleted the bugfix/remove-institution-type-from-product branch September 9, 2024 12:11
@github-actions github-actions bot removed the hotfix label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functions Changes are related to functions libs onboarding-ms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants