Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ops: using cache and 3.9.5 version about maven on workflow #52

Merged
merged 18 commits into from
Nov 28, 2023

Conversation

manuraf
Copy link
Contributor

@manuraf manuraf commented Nov 28, 2023

List of Changes

  1. Implemented the use of the s4u/setup-maven-action action in the GitHub workflows.
  2. Set the Maven version to 3.9.5.
  3. Enabled Maven cache to reduce the execution time of the workflows significantly.
  4. Fix onboarding-ms unit test

Motivation and Context

The entire repository is set up to perform builds using Maven with version 3.9.x. In the current GitHub workflows, using the setup-java action alone results in the use of an older version of Maven. This change is required to ensure that the workflows use the correct Maven version (3.9.x), aligning with the repository's setup. Additionally, the use of Maven cache is crucial for significantly reducing the execution time of the workflows by caching the Java libraries.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

.github/workflows/code_review_functions.yml Outdated Show resolved Hide resolved
.github/workflows/code_review_ms.yml Outdated Show resolved Hide resolved
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@manuraf manuraf merged commit 66ca8ca into develop Nov 28, 2023
6 checks passed
@manuraf manuraf deleted the bugfix/SELC-2862-unit-test branch November 28, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants