Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SELC-5798] feat: modify NAMIRIAL URL from test to container app #556

Merged
merged 4 commits into from
Oct 24, 2024
Merged

[SELC-5798] feat: modify NAMIRIAL URL from test to container app #556

merged 4 commits into from
Oct 24, 2024

Conversation

giulia-tremolada
Copy link
Collaborator

@giulia-tremolada giulia-tremolada commented Oct 18, 2024 •
edited
Loading

List of Changes

  • modify NAMIRIAL URL from test to container app
  • make NAMIRIAL_BASE_URL an environment variable
  • set USER and PASSWORD inside onboarding-sdk

Motivation and Context

How Has This Been Tested?

It was tested by running onboarding-functions locally and setting NAMIRIAL_BASE_URL to the dev container app url

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added functions Changes are related to functions ops libs labels Oct 18, 2024
@giulia-tremolada giulia-tremolada marked this pull request as ready for review October 22, 2024 10:40
@giulia-tremolada giulia-tremolada requested review from a team as code owners October 22, 2024 10:40
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@giulia-tremolada giulia-tremolada merged commit 79b4649 into main Oct 24, 2024
10 checks passed
@giulia-tremolada giulia-tremolada deleted the feature/SELC-5798 branch October 24, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuraf manuraf manuraf approved these changes

Assignees
No one assigned
Labels
functions Changes are related to functions libs ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giulia-tremolada @manuraf