Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SELC-5547] fix: Updated registry managers for ADE and INFOCAMERE #626

Merged
merged 11 commits into from
Dec 13, 2024
Merged

[SELC-5547] fix: Updated registry managers for ADE and INFOCAMERE #626

merged 11 commits into from
Dec 13, 2024

Conversation

pierpaolodidato89
Copy link
Collaborator

@pierpaolodidato89 pierpaolodidato89 commented Dec 4, 2024 •
edited
Loading

List of Changes

Updated registry managers for ADE and INFOCAMERE

Motivation and Context

These changes are necessary to verify if among companies linked to manager, there is the one passed into onboarding request. If not, an exception is thrown

How Has This Been Tested?

I have deployed the feature branch in DEV PNPG

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pierpaolodidato89 pierpaolodidato89 marked this pull request as ready for review December 4, 2024 13:59
@pierpaolodidato89 pierpaolodidato89 requested a review from a team as a code owner December 4, 2024 13:59
Merge branch 'main' of https://github.com/pagopa/selfcare-onboarding …
13791b4 
…into bugfix/SELC-5547

� Conflicts:
�	apps/onboarding-ms/src/main/java/it/pagopa/selfcare/onboarding/entity/registry/RegistryManagerADE.java
�	apps/onboarding-ms/src/main/java/it/pagopa/selfcare/onboarding/entity/registry/RegistryManagerInfocamere.java
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pierpaolodidato89 pierpaolodidato89 merged commit dc9e26a into main Dec 13, 2024
10 checks passed
@pierpaolodidato89 pierpaolodidato89 deleted the bugfix/SELC-5547 branch December 13, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrea-putzu andrea-putzu andrea-putzu approved these changes

Assignees
No one assigned
Labels
onboarding-ms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierpaolodidato89 @andrea-putzu