Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC - 6127] feat: updated onboardingCompletion APIs logic to accept file in input #627

Merged
merged 6 commits into from
Dec 5, 2024

Conversation

gianmarcoplutino
Copy link
Contributor

List of Changes

  • In the various completion APIs, a file has been added to the request as an input parameter
  • the service logic has been revised as these APIs previously exploited a common method which was also used for the onboarding flow from FE
  • the method that uses the complete API has been revised as it is useful for the completion logic. Except that unlike the complete, when the compilation is invoked the Token is also created on the DB

Motivation and Context

This change was necessary because when SM carried out manual onboarding it manually stored the contract on Azure storage. This behavior, in addition to being dangerous and cumbersome, did not even allow the automatic creation of the Token in the collection of the same name on the DB

How Has This Been Tested?

the API was invoked and it was verified that the Token was created on the DB and that the contract was loaded under the correct path

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gianmarcoplutino gianmarcoplutino marked this pull request as ready for review December 4, 2024 17:13
@gianmarcoplutino gianmarcoplutino requested a review from a team as a code owner December 4, 2024 17:13
@gianmarcoplutino gianmarcoplutino merged commit c432134 into main Dec 5, 2024
8 of 10 checks passed
@gianmarcoplutino gianmarcoplutino deleted the feature/SELC-6127 branch December 5, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants