Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-6174] feat: rework onboarding completion logic #642

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

gianmarcoplutino
Copy link
Contributor

List of Changes

-set status to REQUEST in Onboarding completion APIs

Motivation and Context

This change is necessary as SM will first have to create an onboarding request and then invoke another API to load the signed agreement and complete the same request. Here the logic has been revised so that in the case of invoking the API the request is put in Request and the Request phase is executed which includes creation of the contract and saving of the Token on the DB also in the workflowType CONFIRMATION

How Has This Been Tested?

the local ms was started and the api was invoked and onboarding was subsequently completed

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gianmarcoplutino gianmarcoplutino requested a review from a team as a code owner December 10, 2024 16:03
@github-actions github-actions bot added functions Changes are related to functions onboarding-ms labels Dec 10, 2024
@gianmarcoplutino gianmarcoplutino merged commit 157f7c3 into main Dec 10, 2024
3 checks passed
@gianmarcoplutino gianmarcoplutino deleted the feature/SELC-6174 branch December 10, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functions Changes are related to functions onboarding-ms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants