Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SELC-6140] feat: manage aggregates csv for SEND #662

Merged
merged 1 commit into from
Jan 9, 2025
Merged

[SELC-6140] feat: manage aggregates csv for SEND #662

merged 1 commit into from
Jan 9, 2025

Conversation

giulia-tremolada
Copy link
Collaborator

List of Changes

  • implement aggregates csv creation for SEND by invocking user registry
  • align unit tests

Motivation and Context

How Has This Been Tested?

It was tested locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added the functions Changes are related to functions label Jan 8, 2025
AleDore
AleDore reviewed Jan 8, 2025
View reviewed changes
Copy link

@AleDore AleDore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giulia-tremolada : can we move this PR in Ready for Review?

@giulia-tremolada giulia-tremolada marked this pull request as ready for review January 8, 2025 10:55
@giulia-tremolada giulia-tremolada requested a review from a team as a code owner January 8, 2025 10:55
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@giulia-tremolada giulia-tremolada merged commit e23288f into main Jan 9, 2025
8 of 9 checks passed
@giulia-tremolada giulia-tremolada deleted the feature/SELC-6140 branch January 9, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleDore AleDore AleDore approved these changes

Assignees
No one assigned
Labels
functions Changes are related to functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giulia-tremolada @AleDore