Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SELC-3493] feat: Reject Endpoint for Enhanced Onboarding Process Approval #96

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

manuraf
Copy link
Contributor

@manuraf manuraf commented Jan 19, 2024

List of Changes

Refactor PUT endpoint /deleted with /reject. DELETED is not used in onboarding lifecycle so this endpoint is designed to reject the data provided during the onboarding process.

Motivation and Context

It is used during admin approval phase if the admin does not want to approve the onboarding request

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@manuraf manuraf requested a review from a team as a code owner January 19, 2024 10:43
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@manuraf manuraf merged commit e6cf5de into main Jan 19, 2024
5 checks passed
@manuraf manuraf deleted the feature/SELC-3493-reject branch January 19, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant