Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing regex solution. #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implementing regex solution. #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
def word_in_string?(word, string)
# implement with your code here
!!(string =~ /(?<![a-z])#{word}(?![a-z])/i) ? :yes : :no
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to cast the =~ operator's return value to boolean with !!. The ternary operator will work fine with the nil or number it returns.

Not every ruby developer agrees, but I avoid using !! to cast to boolean unless strictly required (like when serializing to JSON). Some ruby devs think predicate methods (like #foo?) should only return true or false, but Ruby's core and stdlib don't behave that way. ¯\_(ツ)_/¯

end