Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore AutoService warnings locally #7063

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

ignore AutoService warnings locally #7063

wants to merge 2 commits into from

Conversation

rhuffy
Copy link
Contributor

@rhuffy rhuffy commented Mar 25, 2024

General

Before this PR:
@SuppressWarnings("AutoService") sometimes does not get picked up by the compiler on incremental builds, which causes local builds to fail.

After this PR:

==COMMIT_MSG==
ignore AutoService warnings locally
==COMMIT_MSG==

@jeremyk-91

@changelog-app
Copy link

changelog-app bot commented Mar 25, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

ignore AutoService warnings locally

Check the box to generate changelog(s)

  • Generate changelog entry

Copy link
Contributor

@jeremyk-91 jeremyk-91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, I think the change makes sense. Though do we know if this is documented anywhere / is there a good place for us to know when we can remove this?

@rhuffy
Copy link
Contributor Author

rhuffy commented Mar 27, 2024

I don't think this is being tracked anywhere internally. Just a few slack threads where people have run into this. It's an intermittent error and ./gradlew clean is another workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants