Upgrade to target compile 17 #7413

fsamuel-bs · 2024-10-31T11:06:47Z

General

After this PR:
Upgrade AtlasDB to java 17. Follow up of #7306.

Changes:

remove com.google.common.primitives.Longs references
upgrade several dependencies

What needs to be done in the future:

upgrade to Dagger 2.52+ done in conjunction to adding jakarta dependencies. Because dagger.internal.Provider added a dependency on jakarta.inject.Inject.
upgrade to junit 5.11.0+ needs to be accompanied with a dropwizard upgrade to 3.0+. Because DropwizardExtensionsSupport uses an internal method from junit that has been removed.
- note that org.mockito:* = 5.14.1 also bumps junit to 5.11.0+

==COMMIT_MSG==
==COMMIT_MSG==

changelog-app · 2024-10-31T11:06:51Z

Generate changelog in `changelog/@unreleased`

What do the change types mean?

feature: A new feature of the service.
improvement: An incremental improvement in the functionality or operation of the service.
fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
and external consumers of the service's API (e.g. customer-written software or integrations).
deprecation: Advertises the intention to remove service functionality without any change to the
operation of the service itself.
manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
performing database surgery, ...) at the time of upgrade for it to succeed.
migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?

❗The break and manual task changelog types will result in a major release!
🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
✨ All others will result in a minor version release.

Type

Description

Upgrade AtlasDB to target compile 17

Check the box to generate changelog(s)

Generate changelog entry

fsamuel-bs · 2024-10-31T11:28:19Z

versions.props

-# Large internal product uses 2.x
-org.codehaus.groovy:* = 2.5.14


Confirmed they have upgraded to 3.x

fsamuel-bs · 2024-10-31T11:28:27Z

versions.props

-# Subsequent versions use Java 17, which we don't use right now.
-com.palantir.goethe:* = 0.12.0


We're now in java 17

fsamuel-bs · 2024-10-31T11:28:40Z

versions.props

+
+# Large internal consumer still relies on protobuf 3.x.
+# We need to bump this in coordination with them.
+com.google.protobuf:* = 3.25.4


Pinned from above to 3.x

fsamuel-bs · 2024-10-31T11:28:51Z

versions.props

+org.mockito:* = 5.12.0
+
+# Dagger 2.52.0+ adds a dependency on jakarta. Bump this with the javax -> jakarta migration.
+com.google.dagger:* = 2.51.1


Explanation inline, pinned from above.

fsamuel-bs · 2024-10-31T11:29:00Z

versions.props

+org.junit.jupiter:* = 5.10.2
+org.junit.platform:* = 1.10.2
+org.mockito:* = 5.12.0


Explanation inline, pinned from above.

fsamuel-bs · 2024-10-31T11:29:16Z

versions.props

-org.awaitility:awaitility = 4.2.1
+org.assertj:* = 3.26.3
+org.awaitility:awaitility = 4.2.2
+org.codehaus.groovy:* = 3.0.9


Unpinned from below.

fsamuel-bs · 2024-10-31T11:29:32Z

versions.props

 com.palantir.docker.proxy:* = 1.6.0
+com.palantir.goethe:* = 0.12.0


Unpinned from below.

fsamuel-bs · 2024-10-31T11:29:59Z

versions.props

 com.palantir.conjure.java:* = 8.28.0
 com.palantir.conjure:conjure = 4.49.0
-com.palantir.dialogue:* = 3.135.0
+com.palantir.dialogue:* = 4.1.0


Major version bump, but it's fine since most internal products are on 4.x already.

yeah confirmed large product is on 4.x

fsamuel-bs · 2024-10-31T11:30:07Z

versions.props

 # Ksp version is temporary, can be removed once Maven calms down.
 com.google.devtools.ksp:symbol-processing-api = 1.5.21-1.0.0-beta07
 com.google.errorprone:* = 2.10.0 # upgrading to 2.11.0 is blocked by a google bug
 com.google.errorprone:error_prone_annotations = 2.10.0
-com.google.guava:guava = 33.2.1-jre
-com.google.protobuf:* = 3.25.3


Pinned below.

fsamuel-bs · 2024-10-31T11:30:14Z

versions.props

@@ -10,73 +10,70 @@ com.google.auto.service:auto-service-annotations = 1.0
 com.google.auto:auto-common = 1.2.2
 com.google.code.findbugs:findbugs-annotations = 3.0.1
 com.google.code.findbugs:jsr305 = 3.0.2
-com.google.dagger:* = 2.51.1


Pinned below.

atlasdb-processors/src/main/java/com/palantir/processors/AutoDelegateProcessor.java

jeremyk-91

Thanks! Couple of small bits 👍

jeremyk-91 · 2024-10-31T14:10:43Z

versions.props

 com.palantir.conjure.java:* = 8.28.0
 com.palantir.conjure:conjure = 4.49.0
-com.palantir.dialogue:* = 3.135.0
+com.palantir.dialogue:* = 4.1.0


yeah confirmed large product is on 4.x

jeremyk-91 · 2024-10-31T14:13:02Z

versions.lock

-com.zaxxer:HikariCP:5.1.0 (1 constraints: 08050736)
-commons-cli:commons-cli:1.8.0 (3 constraints: 7e249d97)
-commons-codec:commons-codec:1.17.0 (2 constraints: 6d148085)
+com.zaxxer:HikariCP:6.0.0 (1 constraints: 08050936)


👀 Do we know what changed here?

Tagging @berler @CVdV-au in case they can advise

riCP/blob/dev/CHANGES

ergo14

thanks for the sign posted bumps, looks good to me modulo the hikari bump

…elegateProcessor.java Co-authored-by: Carter Kozak <[email protected]>

svc-excavator-bot and others added 7 commits October 30, 2024 14:30

Excavator: Allow Java 17 language features in all modules

78a01d5

suppress warning

0e3a013

poke

b8183d8

poke

53eb316

remove clojure

20bdc09

downgrade dagger

2a52427

downgrade junit

593349a

fsamuel-bs requested a review from ergo14 October 31, 2024 11:07

svc-changelog and others added 2 commits October 31, 2024 11:21

Add generated changelog entries

180b685

re-jigger deps

2ab3503

fsamuel-bs commented Oct 31, 2024

View reviewed changes

versions.props

com.palantir.docker.proxy:* = 1.6.0

com.palantir.goethe:* = 0.12.0

Copy link

Contributor Author

fsamuel-bs Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unpinned from below.

fsamuel-bs commented Oct 31, 2024

View reviewed changes

carterkozak reviewed Oct 31, 2024

View reviewed changes

atlasdb-processors/src/main/java/com/palantir/processors/AutoDelegateProcessor.java Outdated Show resolved Hide resolved

jeremyk-91 approved these changes Oct 31, 2024

View reviewed changes

ergo14 reviewed Oct 31, 2024

View reviewed changes

fsamuel-bs and others added 2 commits October 31, 2024 14:46

Update atlasdb-processors/src/main/java/com/palantir/processors/AutoD…

fe840c5

…elegateProcessor.java Co-authored-by: Carter Kozak <[email protected]>

downgrade hikari

fb93f24

fsamuel-bs added the merge when ready label Oct 31, 2024

bulldozer-bot bot merged commit 7491a87 into develop Oct 31, 2024
21 checks passed

bulldozer-bot bot deleted the ssouza/java-17 branch October 31, 2024 17:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to target compile 17 #7413

Upgrade to target compile 17 #7413

fsamuel-bs commented Oct 31, 2024 •

edited

Loading

changelog-app bot commented Oct 31, 2024 •

edited by fsamuel-bs

Loading

fsamuel-bs Oct 31, 2024

fsamuel-bs Oct 31, 2024

fsamuel-bs Oct 31, 2024

fsamuel-bs Oct 31, 2024

fsamuel-bs Oct 31, 2024

fsamuel-bs Oct 31, 2024

fsamuel-bs Oct 31, 2024

fsamuel-bs Oct 31, 2024

jeremyk-91 Oct 31, 2024

fsamuel-bs Oct 31, 2024

fsamuel-bs Oct 31, 2024

jeremyk-91 left a comment

jeremyk-91 Oct 31, 2024

jeremyk-91 Oct 31, 2024

ergo14 Oct 31, 2024

ergo14 Oct 31, 2024

ergo14 left a comment

		# Large internal product uses 2.x
		org.codehaus.groovy:* = 2.5.14

		# Subsequent versions use Java 17, which we don't use right now.
		com.palantir.goethe:* = 0.12.0

		com.palantir.docker.proxy:* = 1.6.0
		com.palantir.goethe:* = 0.12.0

Upgrade to target compile 17 #7413

Upgrade to target compile 17 #7413

Conversation

fsamuel-bs commented Oct 31, 2024 • edited Loading

General

changelog-app bot commented Oct 31, 2024 • edited by fsamuel-bs Loading

Generate changelog in changelog/@unreleased

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeremyk-91 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ergo14 left a comment

Choose a reason for hiding this comment

fsamuel-bs commented Oct 31, 2024 •

edited

Loading

changelog-app bot commented Oct 31, 2024 •

edited by fsamuel-bs

Loading

Generate changelog in `changelog/@unreleased`