Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch upcoming React 18 SFC compile breaks in [email protected] #7146

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

ggdouglas
Copy link
Contributor

@ggdouglas ggdouglas commented Jan 10, 2025

Copied from React 18 Upgrade feature branch #7142

Proposed changes:

This change patches the [email protected] used in the @blueprint/datetime library in order to prevent type compile breaks by some deprecated types included with the library. Specifically, it fixes the following:

../../node_modules/react-day-picker/types/Props.d.ts:47:13 - error TS2694: Namespace 'React' has no exported member 'SFC'.
       47     | React.SFC<CaptionElementProps>;
                      ~~~
       ../../node_modules/react-day-picker/types/Props.d.ts:72:13 - error TS2694: Namespace 'React' has no exported member 'SFC'.

       72     | React.SFC<NavbarElementProps>;
                      ~~~
       ../../node_modules/react-day-picker/types/Props.d.ts:145:13 - error TS2694: Namespace 'React' has no exported member 'SFC'.

       145     | React.SFC<WeekdayElementProps>;
                       ~~~

This patch was generated via yarn patch.

@svc-palantir-github
Copy link

Patch upcoming React 18 SFC compile breaks in [email protected]

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas mentioned this pull request Jan 10, 2025
13 tasks
@palantir palantir deleted a comment from changelog-app bot Jan 10, 2025
@ggdouglas ggdouglas merged commit fc04fda into develop Jan 10, 2025
12 of 14 checks passed
@ggdouglas ggdouglas deleted the feat/react-18-patch-react-day-picker branch January 10, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants