fix: Report duration of client.response
metric in microseconds
#515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to palantir/witchcraft-go-server#652
Before this PR
client.response
metric was reported with resolution in milliseconds, even though the convention with the Java implementation of Conjure is to report it in microseconds. This results in response latency being reported with values that are 1000x faster than they actually are.After this PR
==COMMIT_MSG==
Report duration of
client.response
metric in microseconds.==COMMIT_MSG==
You can also check the reasoning by running the following test locally:
Possible downsides?
This might cause some confusion as the value will be reported correctly now. As a result, if looking at a longer time-frame, a user might think that the endpoint was responding much faster in the past, but got 1000x slower after this problem was fixed.