-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feature: new error type Service Unavailable #543
base: develop
Are you sure you want to change the base?
Conversation
Generate changelog in
|
@@ -152,6 +158,8 @@ func (ec *ErrorCode) UnmarshalText(data []byte) error { | |||
*ec = CustomClient | |||
case "CUSTOM_SERVER": | |||
*ec = CustomServer | |||
case "SERVICE_UNAVAILABLE": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we accepting that these can not be included in generated errors? Otherwise this needs to be added to the enum here: https://github.com/palantir/conjure/blob/3d0fec99877ca6dbe899d3faba43c4b45866e9da/conjure-api/src/main/conjure/conjure-api.yml#L46
Slight preference to handle these in a different way that doesn't produce a response body (similar to the java |
Summary
==COMMIT_MSG==
Adding new ServiceUnavailable error code with status code 503 StatusServiceUnavailable
==COMMIT_MSG==