Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opt out of the TypeFactory cache until we can resolve cache contention #2595

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Opt out of the TypeFactory cache until we can resolve cache contention #2595

merged 2 commits into from
Apr 13, 2023

Commits on Apr 12, 2023

  1. Opt out of the TypeFactory cache until we can resolve cache contention 

    FasterXML/jackson-databind#3876
FasterXML/jackson-benchmarks#5

The linked benchmarks show a small advantage of caching over
not caching in most cases, in the best case for a cache: when
a single operation is repetedly executed. In practice, the cache
is used for all operations and sees heavy evictions, where contention
is more likely and has greater impact on users.

Given the hash collision issues that we're aware of, and the impacts
we've observed, we will remove the cache until a version is available
which isn't impacted by the linked issue for performance that's
more predictable.
    @carterkozak
    carterkozak committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    c976bd1 View commit details
    Browse the repository at this point in the history

  2. Add generated changelog entries

    @svc-changelog
    svc-changelog committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    54646bb View commit details
    Browse the repository at this point in the history