Support exclusion of empty collections using experimentalExcludeEmptyCollections
#1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yCollections` This matches empty optional exclusion, including discovery and remediation of a bug: Aliases may be excluded, however they were not handled correctly in the other direction, where null values were handled correctly. Now we initialize builder instances with a reference to an empty instance of alias types. This includes a new `public static T empty()` method on aliases which can handle defaults. The current implementation only checks one level of alias indirection, so alias-of-alias-of-optional/collection still won't do quite what we want, but it's a start.
Generate changelog in
|
carterkozak
commented
Feb 22, 2022
| @@ -44,4 +46,8 @@ public int hashCode() { | |||
| public static SetAlias of(@Nonnull Set<String> value) { | |||
| return new SetAlias(value); | |||
| } | |||
|
|
|||
| public static SetAlias empty() { | |||
There was a problem hiding this comment.
I also considered of() rather than empty(), matching empty object factory method, but I think this is more descriptive.
There was a problem hiding this comment.
Yeah, no strong preference myself. empty() sounds good!
|
Current state looks reasonable to me! 👍 |
|
Released 6.29.0 |
Linking the issue for future reference because I think its part of the reason here? palantir/conjure-typescript#78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches empty optional exclusion, including discovery
and remediation of a bug:
Aliases may be excluded, however they were not handled correctly
in the other direction, where null values were handled correctly.
Now we initialize builder instances with a reference to an empty
instance of alias types. This includes a new
public static T empty()method on aliases which can handle defaults.
The current implementation only checks one level of alias indirection,
so alias-of-alias-of-optional/collection still won't do quite what we
want, but it's a start. Eventually we should consolidate this code.
Staged Builders
Note that this change could impact staged builders which consider
alias<optional/collection>a required field, however such a change would be an abi break. Staged builders are not impacted by this change.Non-staged builders will no longer throw when
alias<optional/collection>are not explicitly set, matching the behavior of an optional/collection field.After this PR
==COMMIT_MSG==
Support exclusion of empty collections using
experimentalExcludeEmptyCollections==COMMIT_MSG==
Possible downsides?
Super duper dangerous if this is set on servers because our typescript clients do not fully implement conjure.