Optimized Jackson Deserialization for Optimized List of Primitives #2431
+68
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterkozak
reviewed
Jan 10, 2025
| @@ -601,11 +601,12 @@ private Iterable<MethodSpec> createSetters( | |||
| Map<com.palantir.conjure.spec.TypeName, TypeDefinition> typesMap, | |||
| boolean override, | |||
| boolean strict) { | |||
| Collection<MethodSpec> setters = Lists.newArrayListWithExpectedSize(fields.size()); | |||
| // Each field tends to fan out into many setters | |||
There was a problem hiding this comment.
This is only true of container types (optional/set/list), not standard fields. Difficult to tell whether a 5x multiplier is ideal or not, but probably not worth spending much time optimizing
|
Released 8.37.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Comment that inspired this work: #2389 (comment)
Previously, Jackson deserialization would pass through a generated setter leveraging an
Iterable<Type>which inherently boxes the type to ultimately unbox while storing it in the optimized storage.After this PR
This changes simply moves the
JacksonSetterto the non box'd setter for these optimized situations.