Add brandedAliases option for strongly branded aliases #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
alexdlm
commented
Aug 10, 2022
| @@ -106,6 +106,7 @@ export { integrationSecond }; | |||
|
|
|||
| const irDir = path.join(__dirname, "../../../../build/ir-test-cases"); | |||
| const testCaseDir = path.join(__dirname, "resources/test-cases"); | |||
| const brandedTestCaseDir = path.join(__dirname, "resources/branded-test-cases"); | |||
There was a problem hiding this comment.
I was torn on duplicating the test-cases again and having a whole other copy of these generated files for this generatorTest, but I think it's good to be clear and actually differentiate the flavored from branded.
It does make for some noise now in this PR though, at least you can skip over anything src/commands/generate/__tests__/resources/branded-test-cases/** (they're also the only added files)
alexdlm
commented
Aug 10, 2022
Comment on lines
-85
to
+99
| `\t${FLAVOR_TYPE_FIELD}?: "${definition.typeName.name}",`, | ||
| `\t${FLAVOR_PACKAGE_FIELD}?: "${definition.typeName.package}",`, | ||
| `\t${FLAVOR_TYPE_FIELD}${maybeOptional}: "${definition.typeName.name}",`, | ||
| `\t${FLAVOR_PACKAGE_FIELD}${maybeOptional}: "${definition.typeName.package}",`, |
There was a problem hiding this comment.
This is the only actual generator change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Flavored aliases are great but don't quite afford enough type safety in projects that require stricter typing to avoid accidental misuse, at the cost of requiring more intentional type assertions.
Hopefully the readme additions describe/justify the difference and tradeoff between flavorizing & branded.
After this PR
==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?