Support http OPTIONS #802
Merged
Support http OPTIONS #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
iamdanfox
commented
May 29, 2020
dialogue-okhttp-client/src/main/java/com/palantir/dialogue/OkHttpChannel.java
Outdated
Show resolved
Hide resolved
|
👍 |
carterkozak
reviewed
May 29, 2020
simulation/src/main/java/com/palantir/dialogue/core/SimulationServer.java
Outdated
Show resolved
Hide resolved
carterkozak
reviewed
May 29, 2020
dialogue-target/src/main/java/com/palantir/dialogue/HttpMethod.java
Outdated
Show resolved
Hide resolved
carterkozak
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/OPTIONS is an HTTP verb that all of our servers implement because browser CORS preflight requests require it. Just like 'PATCH', I'm not intending this to be usable from conjure defined APIs, but it will be a useful implementation detail of the $ saving PR: #794
After this PR
==COMMIT_MSG==
Endpoints can now specify http OPTIONS verb
==COMMIT_MSG==
Possible downsides?