split compile into api/implementation, stop depending on conjure #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
pkoenig10
approved these changes
Nov 15, 2019
CRogers
reviewed
Nov 15, 2019
| import com.palantir.docker.compose.report.Report; | ||
|
|
||
| class ReportPoster { | ||
| private static final ObjectMapper OBJECT_MAPPER = ObjectMappers.newClientObjectMapper(); | ||
| private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper(); |
There was a problem hiding this comment.
Does this definitely produce the same json output?
|
Curious: is there any particular reason that the |
|
removing conjure isn't strictly necessary, it's just tech-debt that you hit in #323 (yeah conjure-java-jackson-serialization is a small lib but having the fewest external dependencies makes for an easier time dealing with jar conflicts) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.