Skip to content

Commit

Permalink
Remove VerifyLocksFailureReporter (#84)
Browse files Browse the repository at this point in the history
  • Loading branch information
pkoenig10 authored Jun 11, 2024
1 parent f24c079 commit 7e076ad
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 102 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,7 @@ private static void reportFailures(File outputFile, Throwable buildThrowable) th
ImmutableList.Builder<FailureReport> failureReports = ImmutableList.builder();
for (TaskExecutionException taskExecutionException : getTaskExecutionExceptions(buildThrowable)) {
Task task = taskExecutionException.getTask();
if (task.getName().equals("verifyLocks")) {
failureReports.add(VerifyLocksFailureReporter.getFailureReport(task));
} else if (task instanceof JavaCompile) {
if (task instanceof JavaCompile) {
// TODO(crogoz): use compileFailuresService to report the errors once everything is on gradle >= 8.6
// for now this is a noop, once the {@link CompileFailuresService} is closed, it will report all the
// errors that were collected
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -330,50 +330,6 @@ class FailureReportsProjectsPluginIntegrationSpec extends IntegrationSpec {
gradleVersionNumber << GRADLE_VERSIONS
}

def '#gradleVersionNumber: verifyLocks reports failures' () {
setup:
gradleVersion = gradleVersionNumber
// language=gradle
buildFile << '''
buildscript {
repositories {
mavenCentral() { metadataSources { mavenPom(); ignoreGradleMetadataRedirection() } }
}
dependencies {
classpath 'com.palantir.gradle.consistentversions:gradle-consistent-versions:2.18.0'
}
}
repositories {
mavenCentral() { metadataSources { mavenPom(); ignoreGradleMetadataRedirection() } }
}
apply plugin: 'com.palantir.failure-reports'
apply plugin: 'com.palantir.consistent-versions'
apply plugin: 'java'
dependencies {
implementation 'com.squareup.okhttp3:okhttp'
}
'''.stripIndent(true)

buildFile << setDefaultReportsOutputFiles(gradleVersionNumber)

file('versions.props').text = 'com.squareup.okhttp3:okhttp = 3.12.0'
file('versions.lock').text = ''

enableTestCiRun()

when:
runTasksWithFailure('verifyLocks')

then:
CheckedInExpectedReports.checkOrUpdateFor(projectDir, "verifyLocks", getDefaultOutputFile(gradleVersionNumber))

where:
gradleVersionNumber << GRADLE_VERSIONS
}

def '#gradleVersionNumber: ExceptionWithSuggestion is reported as a failure' () {
setup:
gradleVersion = gradleVersionNumber
Expand Down

This file was deleted.

0 comments on commit 7e076ad

Please sign in to comment.