Support graal jdk automanagement installations #497
Conversation
Generate changelog in
|
…dle-jdks into cr/graal-jdk-automanagement
| setupGradleDirectoryStructure(Os.LINUX_GLIBC); | ||
| dockerBuildAndRunTestingScript("ubuntu:20.04", "/bin/bash", INSTALL_CURL, true); | ||
| } | ||
|
|
||
| @Test | ||
| public void can_setup_jdks_alpine() throws IOException, InterruptedException { |
There was a problem hiding this comment.
not supporting musl distros for jdk automanagement. Graal doesn't seem to support this either.
There was a problem hiding this comment.
We still try to install them though right? I'd say we'd probably want to keep the test for them (but not for graal?) while we still do.
| @@ -141,11 +141,11 @@ install_and_setup_jdks() { | |||
| case "$distribution_url" in | |||
| *.zip) | |||
| distribution_name=${distribution_url##*/} | |||
| curl -C - "$distribution_url" -o "$distribution_name" | |||
| curl -L -C - "$distribution_url" -o "$distribution_name" | |||
There was a problem hiding this comment.
allow curl to follow redirects
| os(jdkRelease.os()), | ||
| arch(jdkRelease.arch()), | ||
| splitVersion.graalVersion()); | ||
| "jdk-%s/graalvm-community-jdk-%s_%s-%s_bin", |
There was a problem hiding this comment.
It looks like it changed at some point. We probably want to handle downloading old ones too:
- 23.0.2: https://github.com/graalvm/graalvm-ce-builds/releases/download/jdk-23.0.2/graalvm-community-jdk-23.0.2_linux-x64_bin.tar.gz
- 22.3.2: https://github.com/graalvm/graalvm-ce-builds/releases/download/vm-22.3.2/graalvm-ce-java17-linux-amd64-22.3.2.tar.gz
I don't exactly know when it changed over.
There was a problem hiding this comment.
they started to match the graalVM version with the java version, previously for a specific graalvm version (eg. 22.3 - https://www.graalvm.org/release-notes/22_3/ you could install either the java11 or java17 based GraalVM), now when we specify graalVm == 22.3 -> we will be getting the java version == 22.3 https://www.graalvm.org/release-notes/JDK_22/)
|
Released 0.61.0 |
Before this PR
After this PR
In preparation for graal'ing palantir-java-format. Adds support for graal distributions (drops support for older graal download urls, updates the download urls).
Not currently supported/Limitations:
==COMMIT_MSG==
Support graal jdk automanagement installations
==COMMIT_MSG==
Possible downsides?