Check if ontology RID starts with "ri." (#815)

palantir · Oct 7, 2024 · d927a1d · d927a1d
1 parent 5e78575
commit d927a1d
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/.changeset/few-apes-visit.md b/.changeset/few-apes-visit.md
@@ -0,0 +1,6 @@
+---
+"@osdk/shared.test": patch
+"@osdk/client": patch
+---
+
+Throws error in createClient when passed an invalid ontology RID
diff --git a/packages/client/src/createClient.ts b/packages/client/src/createClient.ts
@@ -82,6 +82,18 @@ export function createClientInternal(
   options: { logger?: Logger } | undefined = undefined,
   fetchFn: typeof globalThis.fetch = fetch,
 ): Client {
+  if (typeof ontologyRid === "string") {
+    if (!ontologyRid.startsWith("ri.")) {
+      throw new Error("Invalid ontology RID");
+    }
+  } else {
+    ontologyRid.then((ontologyRid) => {
+      if (!ontologyRid.startsWith("ri.")) {
+        throw new Error("Invalid ontology RID");
+      }
+    });
+  }
+
   const clientCtx: MinimalClient = createMinimalClient(
     { ontologyRid },
     baseUrl,

diff --git a/packages/shared.test/src/mock-ontology/mockOntology.ts b/packages/shared.test/src/mock-ontology/mockOntology.ts
@@ -187,7 +187,7 @@ const updateTask: ActionDef$updateTask = {
 
 export const MockOntology = {
   metadata: {
-    ontologyRid: "",
+    ontologyRid: "ri.filler",
     ontologyApiName: "Ontology",
     userAgent: "typescript-sdk/0.0.0 osdk-cli/0.0.0",
   },