Prep work for splitting clis #1086
Open
+323
−211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericanderson
commented
Jan 10, 2025
| "@osdk/generator": "workspace:~", | ||
| "@osdk/cli.common": "workspace:*", | ||
| "@osdk/generator": "workspace:*", | ||
| "@osdk/generator-utils": "workspace:*", |
There was a problem hiding this comment.
For these we don't want surprises so we are locking exactly in.
| @@ -47,6 +55,14 @@ beforeEach(() => { | |||
| describe.each(TEMPLATES)("template $id", (template) => { | |||
| const supportedVersions = Object.keys(template.files); | |||
| describe.each(supportedVersions)("For SDK version %s", (sdkVersion) => { | |||
| beforeAll(() => { | |||
| vi.stubEnv("STABLE_PACKAGE_CLIENT_VERSION", "2.1.0-beta.20"); | |||
There was a problem hiding this comment.
We don't run babel or anything for tests
| @@ -18,6 +18,7 @@ import { findUp } from "find-up"; | |||
| import { readFile } from "fs/promises"; | |||
| import * as path from "node:path"; | |||
|
|
|||
| process.env.STABLE_PACKAGE_CLIENT_VERSION = "~2.0.11"; | |||
There was a problem hiding this comment.
After we move this to the other repo, we can put a devDependency on @osdk/client in the packages that need this and can just read from there instead of doing the hard coding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ultimate goal is to move a bunch of packages to
osdk-ts-clis, specifically:@osdk/create-app@osdk/create-app.*@osdk/create-widget@osdk/create-widget.*@osdk/cli@osdk/cli.common@osdk/example-generatorNOTE: Intent is to keep
cli.cmd.typescriptin this repo still.This meant:
create-appbeing the exact same as theclient. (We now need to hard code theSTABLE_PACKAGE_CLIENT_VERSION.@osdk/cli.cmd.typscriptnot private. (We need to be able to depend on it from the other repo)@osdk/cli.commonnot private. (Its going to move to the other repo but we need to be able to depend on it)handleGenerate.mts->handleGenerate.ts)Additional changes in here:
tsupwas doing some duplicative work related to havingshims: trueand thought this would not be needed any more as we don't need to have__dirnamein our code since everything is a module now.__dirnameentries, I had to fix a few places in the code that weren't using theimport.meta.urlmethod, and I renamed all the times we doconst __dirname = path.dirname(fileURLToPath(import.meta.url));to a different name so I could validate in the output there wasn't any uses of__dirname.