follow the API guidelines and only update when formatted file is changed

palantir · Jan 9, 2025 · ae2a2c2 · ae2a2c2
1 parent d32aabe
commit ae2a2c2
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/...n/src/main/java/com/palantir/javaformat/intellij/PalantirJavaFormatFormattingService.java b/...n/src/main/java/com/palantir/javaformat/intellij/PalantirJavaFormatFormattingService.java
@@ -88,11 +88,21 @@ public void run() {
                 return;
             }
 
+            String preFormatText = request.getDocumentText();
+
             try {
                 String formattedText = applyReplacements(
                         request.getDocumentText(),
                         formatterService.get().getFormatReplacements(request.getDocumentText(), toRanges(request)));
-                request.onTextReady(formattedText);
+
+                // The Javadoc of this API says that you should set it to null when the document is unchanged
+                // We should not be trying to format a document that is already formatted
+                if (preFormatText.equals(formattedText)) {
+                    request.onTextReady(null);
+                } else {
+                    request.onTextReady(formattedText);
+                }
+
             } catch (FormatterException e) {
                 request.onError(
                         Notifications.PARSING_ERROR_TITLE,