Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #975: last character not a \n after format in Intellij #1113

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix issue #975: last character not a \n after format in Intellij #1113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da6f6dd
fix https://github.com/palantir/palantir-java-format/issues/975
bodote Aug 11, 2024
78818d3
added changelog
bodote Aug 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/@unreleased/pr-1113.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: fix
fix:
description: "fix issue #975: last character not a \n after format in Intellij"
links:
- https://github.com/palantir/palantir-java-format/pull/1113
2 changes: 1 addition & 1 deletion ...n/src/main/java/com/palantir/javaformat/intellij/PalantirJavaFormatFormattingService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public void run() {
String formattedText = applyReplacements(
request.getDocumentText(),
formatterService.get().getFormatReplacements(request.getDocumentText(), toRanges(request)));
request.onTextReady(formattedText);
request.onTextReady(formattedText.trim() + "\n");
} catch (FormatterException e) {
request.onError(
Notifications.PARSING_ERROR_TITLE,
Expand Down