separate action generation logic: fix linting problem

palantir · Oct 29, 2019 · 8242066 · 8242066
1 parent 4ae20c8
commit 8242066
Showing 1 changed file with 25 additions and 19 deletions.
diff --git a/pyls/plugins/importmagic_lint.py b/pyls/plugins/importmagic_lint.py
@@ -129,28 +129,34 @@ def pyls_code_actions(config, document, context):
                 # These tend to be terrible
                 continue
 
-            # Generate the patch we would need to apply
-            imports = importmagic.Imports(index, document.source)
-            if variable:
-                imports.add_import_from(module, variable)
-            else:
-                imports.add_import(module)
-            start_line, end_line, text = imports.get_update()
-
-            actions.append({
-                'title': _command_title(variable, module),
-                'command': ADD_IMPORT_COMMAND,
-                'arguments': [{
-                    'uri': document.uri,
-                    'version': document.version,
-                    'startLine': start_line,
-                    'endLine': end_line,
-                    'newText': text
-                }]
-            })
+            actions.append(generate_add_action(document.source, index, module, variable))
+
     return actions
 
 
+def generate_add_action(document, index, module, variable):
+    # Generate the patch we would need to apply
+    imports = importmagic.Imports(index, document.source)
+    if variable:
+        imports.add_import_from(module, variable)
+    else:
+        imports.add_import(module)
+    start_line, end_line, text = imports.get_update()
+
+    action = {
+        'title': _command_title(variable, module),
+        'command': ADD_IMPORT_COMMAND,
+        'arguments': [{
+            'uri': document.uri,
+            'version': document.version,
+            'startLine': start_line,
+            'endLine': end_line,
+            'newText': text
+        }]
+    }
+    return action
+
+
 @hookimpl
 def pyls_execute_command(workspace, command, arguments):
     if command != ADD_IMPORT_COMMAND: