Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-21+ response-time gc profile uses generational zgc #1520

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

carterkozak
Copy link
Contributor

==COMMIT_MSG==
JDK-21+ response-time gc profile uses generational zgc
==COMMIT_MSG==

@changelog-app
Copy link

changelog-app bot commented Sep 12, 2023

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

JDK-21+ response-time gc profile uses generational zgc

Check the box to generate changelog(s)

  • Generate changelog entry

Copy link
Contributor

@schlosna schlosna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me to get a baseline

// https://openjdk.org/jeps/439
"-XX:+ZGenerational",
// "forces concurrent cycle instead of Full GC on System.gc()"
"-XX:+ExplicitGCInvokesConcurrent");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on https://www.chriswhocodes.com/corretto_jdk11_options.html -XX:+ClassUnloadingWithConcurrentMark defaults to true (and has since jdk-11, I haven't verified earlier releases).

The zgc documentation suggested that numa support is enabled by default, but turned off if the jvm detects it's not needed, but that UseNUMA flag overrides this behavior: https://wiki.openjdk.org/display/zgc/Main#Main-EnablingNUMASupport

@bulldozer-bot bulldozer-bot bot merged commit 317e097 into develop Sep 12, 2023
@bulldozer-bot bulldozer-bot bot deleted the ckozak/generational_z branch September 12, 2023 20:58
@svc-autorelease
Copy link
Collaborator

Released 7.41.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants