Merge pull request #27 from palantir/feature/duplicate-method-names-c…

…onfig fix bug with previous commit
palantir · Feb 26, 2016 · ebf03a0 · ebf03a0
2 parents 0f6bd37 + db1abf8
commit ebf03a0
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/...t-service-generator-core/src/main/java/com/palantir/code/ts/generator/ServiceEmitter.java b/...t-service-generator-core/src/main/java/com/palantir/code/ts/generator/ServiceEmitter.java
@@ -81,7 +81,10 @@ public Result processType(Type javaType, Context context) {
     }
 
     public void emitTypescriptClass() {
-        Set<String> duplicateEndpointNames = getDuplicateEndpointNames();
+        Set<String> endpointsToWarnAboutDuplicateNames = Sets.newHashSet();
+        if (!this.settings.emitDuplicateJavaMethodNames()) {
+            endpointsToWarnAboutDuplicateNames = getDuplicateEndpointNames();
+        }
         writer.writeLine("");
         // Adding "Impl" ensures the class name is different from the impl name, which is a compilation requirement.
         writer.writeLine("export class " + model.name() + "Impl" + " implements " + settings.getSettings().addTypeNamePrefix + model.name() + " {");
@@ -96,7 +99,7 @@ public void emitTypescriptClass() {
         writer.writeLine("}");
 
         for (ServiceEndpointModel endpointModel: model.endpointModels()) {
-            if (duplicateEndpointNames.contains(endpointModel.endpointName())) {
+            if (endpointsToWarnAboutDuplicateNames.contains(endpointModel.endpointName())) {
                 // don't output any duplicates
                 continue;
             }