improvement: Server.WithHealth supports multiple calls by appending #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, all user-provided healthchecks must be provided in a single call to WithHealth. This has forced applications to build their own healthcheck accumulators.
I have written this code in multiple repos:
This behavior change is technically a break if anyone is relying on overwriting the values, but I have not been able to find and example of that use case. I considered adding a new API for this (
AppendHealth
?) but decided the API bloat wasn't worth it. Happy to reconsider if others disagree.This change is