improvement: Automatically rotate log files per Palantir convention #560
Conversation
…ft-go-server into lfdo/lumberjack-rotate
| defer ticker.Stop() | ||
| for { | ||
| // Rotate once at start. If there is no file, it is no op. | ||
| if err := logger.Rotate(); err != nil { |
There was a problem hiding this comment.
I guess there's no way to restart the timer when the file is rotated due to MaxSize? We're going to end up with smaller-than-desired files if we have two uncoordinated thresholds
There was a problem hiding this comment.
There is no way unfortunately. The lumberjack logger doesn't expose the current file size nor when was it last rotated.
| @@ -679,6 +683,11 @@ func (s *Server) Start() (rErr error) { | |||
| } | |||
| } | |||
|
|
|||
| // initialize log flushers | |||
| for _, logFlusher := range s.logFlushers { | |||
There was a problem hiding this comment.
Why bother accumulating these and launching them in *Server? Couldn't this just go periodicallyRotateLogFiles(ctx, logger, slsFilename) in newDefaultLogOutputWriter?
There was a problem hiding this comment.
The rotation function stops if the context is cancelled and we only have a context in the main server function after all loggers are initialized. Basically we want the go routine to exit when the server is stopped.
Summary
Per Palantir convention, we should be rotating and compressing log files on a cadence. Audit logs rotate hourly while the rest rotate daily.
Testing
Tested locally by running the server with a shorter rotation interval and can attest log files are rotated correctly.
Changelog
==COMMIT_MSG==
Automatically rotate log files per Palantir convention
==COMMIT_MSG==
This change is