Report exemplars for histogram and timer metrics #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
We didn't report any exemplars for metrics, making it a bit harder to investigate slowness or other badness.
After this PR
==COMMIT_MSG==
Histogram and timer metrics now report exemplars.
==COMMIT_MSG==
The behavior here matches WC-Java - we report at most a single exemplar per metric, corresponding to the measurement from the sampled trace made within the last reporting window which had the highest value (i.e. was the slowest for a timer metric).
Depends on palantir/witchcraft-rust-logging#40.