Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cw1155-base, cw1155-metadata-onchain, cw1155-royalties #2

Open
wants to merge 262 commits into
base: main
Choose a base branch
from

Conversation

dirtyshab
Copy link

@dirtyshab dirtyshab commented May 1, 2024

This PR adds a basic implementation of ERC-1155 Multi Token Standard, along with the following extensions:

  • On-Chain Metadata
  • On-Chain Royalties (inspired by CW-2981-Royalties)

ref:

taitruong and others added 30 commits February 29, 2024 23:28
- new query GetMinterOwnership and GetCreatorOwnership, deprecated Ownership
- new execute UpdateMinterOwnership and UpdateCreatorOwnership, deprecate UpdateOwnership
- dedicated stores for minter and creator, where creator usess by default cw_ownable singleton!
- new migrate msg allowing to reset creator and minter
- cleanup migration and split legacy part to dedicated functions
- also make sure using decicated CREATOR and MINTER stores and NOT use cw_ownable::...
- move logic from cw721-base to cw721
- merge cw721-base and cw721-metadata-onchain into one, distinction is: `extension: T` where T for base contract is `type DefaultMetadataExtension = Option<Metadata>`
- all logic now in default implementation for traits Cw721Execute and Cw721Query
fix: batch events that involve multiple tokens will emit 1 event instead of multiple, with a comma delimited list of '{token_id}:{amount}'.
fix: remove query IsApprovedForAll - too gas intensive, use query 'ApprovalsFor' instead.
fix: verify_approval/s functions.
chore: rename 'ApprovedForAll' to 'ApprovalsFor'.
chore: TokenAmount struct instead of (token_id, amount) tuple vec.
chore: use workspace deps in cargo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants