Added support non-MSVC toolchains on Windows (fixed #1 issue) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boppybibbles
reviewed
Sep 2, 2023
| @@ -24,25 +24,28 @@ function(win_copy_deps_to_target_dir target) | |||
| set(has_runtime_dll_genex YES) | |||
|
|
|||
| add_custom_command(TARGET ${target} POST_BUILD | |||
| COMMAND ${CMAKE_COMMAND} -P "${mylib_SOURCE_DIR}/cmake/silent_copy.cmake" | |||
| COMMAND ${CMAKE_COMMAND} -P "${mylib_SOURCE_DIR}/cmake/silent_copy.cmake" | |||
There was a problem hiding this comment.
Please revert white space changes.
|
|
||
| set(pdb_files "") | ||
| if (MSVC) | ||
| set(pdb_files "$<TARGET_PDB_FILE:${dep}>") |
There was a problem hiding this comment.
Please use generator expression CXX_COMPILER_ID to get compiler in use.
ArthurKoba
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed utils.cmake to support cmake parsing for toolchains other than MSVC.
Calling silent_copy.cmake with PDB files in arguments now depends on the used complier.