Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type freq in shift #1108

Merged
merged 7 commits into from
Feb 10, 2025
Merged

type freq in shift #1108

merged 7 commits into from
Feb 10, 2025

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Feb 7, 2025 •
edited
Loading

closes #1111

  • Closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added: Please use assert_type() to assert the type of any return value

@MarcoGorelli MarcoGorelli marked this pull request as ready for review February 7, 2025 18:27
@MarcoGorelli MarcoGorelli marked this pull request as draft February 8, 2025 11:54
This was referenced Feb 8, 2025
Open
Closed
@MarcoGorelli MarcoGorelli marked this pull request as ready for review February 8, 2025 12:18
MarcoGorelli
MarcoGorelli commented Feb 8, 2025
View reviewed changes
tests/test_series.py Outdated Show resolved Hide resolved
Dr-Irv
Dr-Irv requested changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change Series.shift() to return Series rather than Self

tests/test_series.py Outdated Show resolved Hide resolved
Dr-Irv
Dr-Irv requested changes Feb 10, 2025
View reviewed changes
pandas-stubs/core/series.pyi Outdated Show resolved Hide resolved
tests/test_series.py Outdated Show resolved Hide resolved
MarcoGorelli
MarcoGorelli commented Feb 10, 2025
View reviewed changes
tests/test_series.py Outdated Show resolved Hide resolved
Dr-Irv
Dr-Irv approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @MarcoGorelli

@Dr-Irv Dr-Irv merged commit 2cc6fa2 into pandas-dev:main Feb 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Irv Dr-Irv Dr-Irv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Series.shift does not always preserve input dtype, but is typed as if it does
2 participants
@MarcoGorelli @Dr-Irv