DOC: Update pandas.core.groupby.GroupBy.pipe docstring #32352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
requested changes
Feb 29, 2020
pandas/core/groupby/groupby.py
Outdated
| Use `.pipe` when you want to improve readability by chaining together | ||
| functions that expect Series, DataFrames, GroupBy or Resampler objects. | ||
| Instead of writing | ||
| Use `.pipe` when you want to improve readability. |
There was a problem hiding this comment.
Can you revert the changes to this paragraph?
pandas/core/groupby/groupby.py
Outdated
| func : callable or tuple of (callable, string) | ||
| Function to apply to this %(klass)s object or, alternatively, | ||
| func : callable or tuple of (callable, str) | ||
| Function to apply to this %(klass)s object or, alternatiy, |
There was a problem hiding this comment.
Suggested change
| Function to apply to this %(klass)s object or, alternatiy, | |
| Function to apply to this %(klass)s object or |
|
@hsjsjsj009 do you have time to address the comments? Would be great to get this merged. |
|
Sorry, I just saw this email, I will do it today.
…On Sun, Mar 8, 2020, 3:41 AM Marc Garcia ***@***.***> wrote:
@hsjsjsj009 <https://github.com/hsjsjsj009> do you have time to address
the comments? Would be great to get this merged.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#32352?email_source=notifications&email_token=ALI76F275UEZU3S2A2VZVV3RGKWQLA5CNFSM4K6NGZHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOEE5QQ#issuecomment-596135618>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALI76FYV7KL5ZXIMV4E5EV3RGKWQLANCNFSM4K6NGZHA>
.
|
|
|
||
| %(versionadded)s | ||
|
|
||
| Use `.pipe` when you want to improve readability by chaining together | ||
| functions that expect Series, DataFrames, GroupBy or Resampler objects. | ||
| Instead of writing | ||
| functions expect Series, DataFrames, GroupBy or Resampler objects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff