DOC: Update pandas.core.groupby.GroupBy.pipe docstring #32531
Conversation
pandas/core/groupby/groupby.py
Outdated
|
|
||
| %(versionadded)s | ||
|
|
||
| Use `.pipe` when you want to improve readability by chaining together | ||
| functions that expect Series, DataFrames, GroupBy or Resampler objects. | ||
| Instead of writing | ||
| Instead of writing. |
There was a problem hiding this comment.
Is this full stop necessary here? It doesn't feel like it's the end of the sentence, could it be changed to "Instead of writing:"?
There was a problem hiding this comment.
Thanks for working on this @hsjsjsj009, and sorry for the late review, not sure why I missed this PR before.
Changes look great. Just one change seems incorrect to me, other than that looks perfect.
Also, when you're done, please have a look at the CI, and make sure it's green, so we can merge. Thanks!
|
|
||
| %(versionadded)s | ||
|
|
||
| Instead of writing: |
There was a problem hiding this comment.
Can you restore this? I think it made more sense where it was. Looks out of context here.
|
Conflicts and stale, closing. @hsjsjsj009 let me know if you want to keep working on this, or feel free to open a new PR with the required changes. |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff