Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #39

Open
wants to merge 119 commits into
base: master
Choose a base branch
from
Open

Testing #39

wants to merge 119 commits into from

Conversation

Alystrasz
Copy link
Member

@Alystrasz Alystrasz commented Jun 15, 2021

  • tests cover application code;
  • those run on CI through a test script;
  • Android and iOS packages are not built if tests fail;
  • coverage report is uploaded at the end of the CI run;
  • introduces required object properties.

A Favorite instance without id would be stored in app caches under
"null" key, which would not raise errors but provoke unwanted
behaviors.
@Alystrasz Alystrasz requested a review from rouvoy June 15, 2021 07:48
@Alystrasz Alystrasz marked this pull request as ready for review June 15, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant