Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to
perf
, a good portion of runtime was spent converting slices ofstr
toi32
in theparse_cigar_to_delta
function.Note that this PR gets rid of the check which makes sure that the number parses correctly (
num_buf.parse::<i32>().map_err(|_| ParseErr::InvalidCigarFormat)?
). As we are already checking if each character is a digit, I don't think there's any way thatnum_buf
would throw anyways (unlessparse
throws if there are leading zeros, I am not sure...).Benchmarks
Input:
Command (the
.impg
index was precomputed).Main branch:
This PR: