Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many CIGAR strings were being parsed multiple times. This PR adds a hashmap which stores recently parsed CIGARs. Right now, the hashmap is cleared once it reaches some predefined size (1000 entries), but that should likely be changed to be dependent on some property of the input. The
fetch_cigar_ops
Also, as far as I understand it, the use of
RefCell
means that theImpg
struct cannot be shared across threads, so if that's an issue other options can be explored. The only reason for usingRefCell
was to avoid making the entire struct mutable for all calls. Another option could be to just keep the hashmap completely separate from the impg struct...Main:
This PR: