Code

[WIP] Change MemoWise public API#247

Code

Closed

paracycle wants to merge 30 commits intopanorama-ed:mainpanorama-ed/memo_wise:mainfrom paracycle:uk-ji-refactorparacycle/memo_wise:uk-ji-refactorCopy head branch name to clipboard

+413-830

Commits

Commits on Dec 13, 2021

• Revert internal data structure to simple hash

  Show description for beb6e07
  JacobEvelyn

  committed
  beb6e07

  Copy full SHA for beb6e07

• Fixed rubocop

  jemmaissroff

  committed
  68a58b2

  Copy full SHA for 68a58b2

• Change prepend MemoWise to extend MemoWise

  Show description for a561d30
  

  paracycle

  and

  jemmaissroff

  committed
  a561d30

  Copy full SHA for a561d30

• Remove initialize override in MemoWise module

  Show description for b6a249c
  

  paracycle

  and

  jemmaissroff

  committed
  b6a249c

  Copy full SHA for b6a249c

• Move memo_wise method top-level in MemoWise module

  Show description for 6687f2d
  

  paracycle

  and

  jemmaissroff

  committed
  6687f2d

  Copy full SHA for 6687f2d

• Add memo_wise_module builder method

  Show description for 4f2882f
  

  paracycle

  and

  jemmaissroff

  committed
  4f2882f

  Copy full SHA for 4f2882f

• Implement the memo_wise self: :foo code path

  Show description for b7ee80e
  

  paracycle

  and

  jemmaissroff

  committed
  b7ee80e

  Copy full SHA for b7ee80e

• Add internal memo wise state to memo wise module

  

  paracycle

  authored and

  jemmaissroff

  committed
  0f39b35

  Copy full SHA for 0f39b35

• Add support for frozen objects to memo wise module

  

  paracycle

  authored and

  jemmaissroff

  committed
  fcfe38c

  Copy full SHA for fcfe38c

• Remove internal state setup related code from memo_wise

  

  paracycle

  authored and

  jemmaissroff

  committed
  b3dac0e

  Copy full SHA for b3dac0e

• Refactor next_index! to be an instance method on InternalAPI

  

  paracycle

  authored and

  jemmaissroff

  committed
  dd0adf5

  Copy full SHA for dd0adf5

• Implement memo_wise method fully

  

  paracycle

  authored and

  jemmaissroff

  committed
  d7ea3fd

  Copy full SHA for d7ea3fd

• Move and simplify the instance_method override

  

  paracycle

  authored and

  jemmaissroff

  committed
  ca088cd

  Copy full SHA for ca088cd

• Get rid of state initialization in self.prepended method

  

  paracycle

  authored and

  jemmaissroff

  committed
  4bf4e63

  Copy full SHA for 4bf4e63

• Remove self.prepended method completely

  

  paracycle

  authored and

  jemmaissroff

  committed
  503e842

  Copy full SHA for 503e842

• Move memo_wise documentation to the correct place

  

  paracycle

  authored and

  jemmaissroff

  committed
  244ca97

  Copy full SHA for 244ca97

• Make build_module a private method

  

  paracycle

  authored and

  jemmaissroff

  committed
  a3f7fd8

  Copy full SHA for a3f7fd8

• Change validate_memo_wised! method to memo_wised_method

  

  paracycle

  authored and

  jemmaissroff

  committed
  4ddb91f

  Copy full SHA for 4ddb91f

• Move preset_memo_wise method inside the MemoWise methods module

  

  paracycle

  authored and

  jemmaissroff

  committed
  40a1e1c

  Copy full SHA for 40a1e1c

• Move reset_memo_wise method inside the MemoWise methods module

  

  paracycle

  authored and

  jemmaissroff

  committed
  5294212

  Copy full SHA for 5294212

• Name the internal module MemoWiseMethods

  

  paracycle

  authored and

  jemmaissroff

  committed
  8c6db07

  Copy full SHA for 8c6db07

• Be a good citizen and return method name from memo_wise

  Show description for 71ff3dc
  

  paracycle

  authored and

  jemmaissroff

  committed
  71ff3dc

  Copy full SHA for 71ff3dc

• Starting to rebase off main

  jemmaissroff

  committed
  0d34696

  Copy full SHA for 0d34696

• WIP

  jemmaissroff

  committed
  4b14648

  Copy full SHA for 4b14648

• Still failing

  jemmaissroff

  committed
  d08f1f4

  Copy full SHA for d08f1f4

• WIP

  jemmaissroff

  committed
  95f57ae

  Copy full SHA for 95f57ae

• Fixing specs

  jemmaissroff

  committed
  d046d0a

  Copy full SHA for d046d0a

Commits on Dec 14, 2021

• All tests passing 🎉

  jemmaissroff

  committed
  6d979c1

  Copy full SHA for 6d979c1

• Removed unused code

  jemmaissroff

  committed
  07f8096

  Copy full SHA for 07f8096

• Fixed rubocop

  jemmaissroff

  committed
  ea14b66

  Copy full SHA for ea14b66