Update Network types locales + add help text on form #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B-Rass
force-pushed
the
341607-update-show-pages
branch
from
cf3d1af
to
117dbe6
Compare
|
@B-Rass did you missed something here? I can't really review this, at least now. |
apparently ... ^^' |
B-Rass
force-pushed
the
344410-update-network-types-locales
branch
from
816d8ee
to
e117137
Compare
@nicolas-brousse fixed |
B-Rass
force-pushed
the
344410-update-network-types-locales
branch
from
e117137
to
ceea4e8
Compare
app/views/modeles/show.html.erb
Outdated
Comment on lines
21
to
25
| <% if network_types = @modele.network_types.presence %> | ||
| <%= network_types.map { |type| Modele.human_attribute_name("network_types.#{type}") }.join(", ") %> | ||
| <% else %> | ||
| <%= Modele.human_attribute_name("network_types.blank") %> | ||
| <% end %> |
There was a problem hiding this comment.
Could be done in a decorator helper?
app/views/servers/show.html.erb
Outdated
Comment on lines
203
to
207
| <% if network_types = @server.network_types.presence %> | ||
| <%= network_types.map { |type| Modele.human_attribute_name("network_types.#{type}") }.join(", ") %> | ||
| <% else %> | ||
| <%= Modele.human_attribute_name("network_types.blank") %> | ||
| <% end %> |
There was a problem hiding this comment.
Could be done in a decorator helper?
nicolas-brousse
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.