Fix out of bound iterator in tests #189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I was trying to build Ruckig w/ tests in Debug and got out-of-bound iterator access errors from some of the tests in
inline void add_profile(ProfileIter& profile)in a couple of places that was captured by asserts in STL.It looks like the issue is with reserving
std::array<Profile, 3>being the size of 3, while theprofileiterator can advance by three fromvalid_profiles.begin()and point tovalid_profiles.end()when being dereferenced eventually.I summarize these behavior in a couple of commits. It would be also nice to add an input validation into
add_profileto fail early in Debug (should be stripped out in Release anyway).Environment: Visual Studio Community 2022 Release - x86_amd64; MSVC 17.9.34728.123; Debug build.