update to the latest pages action so that it might work again #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last docs update failed with: https://github.com/pantsbuild/pantsbuild.org/actions/runs/12934911051/job/36077004632 ``` Getting action download info Download action repository 'actions/checkout@v3' (SHA:f43a0e5ff2bd294095638e18286ca9a3d1956744) Download action repository 'actions/setup-node@v3' (SHA:1a4442cacd436585916779262731d5b162bc6ec7) Download action repository 'actions/cache@v3' (SHA:f4b3439a656ba812b8cb417d2d49f9c810103092) Download action repository 'actions/configure-pages@v3' (SHA:b8130d9ab958b325bbde9786d62f2c97a9885a0e) Download action repository 'actions/upload-pages-artifact@v2' (SHA:a753861a5debcf57bf8b404356158c8e1e33150c) Download action repository 'actions/deploy-pages@v2' (SHA:de14547edc9944350dc0481aa5b7afb08e75f254) Getting action download info Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v3`. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ ``` This is presumably from a transitive dependency from `deploy-pages@v2` to the deprecated action.
6 tasks
|
Should |
|
Whoops, yes I believe that is correct. |
cognifloyd
reviewed
Jan 27, 2025
| @@ -62,4 +62,4 @@ jobs: | |||
| path: "./build" | |||
| - name: Deploy to GitHub Pages | |||
| id: deployment | |||
| uses: actions/deploy-pages@v2 | |||
| uses: actions/deploy-pages@v3 | |||
There was a problem hiding this comment.
The suggestion wasn't to use an older version of this action.
Suggested change
| uses: actions/deploy-pages@v3 | |
| uses: actions/deploy-pages@v4 |
Instead, bump the version of actions/upload-pages-artifact on line 60.
tdyas
approved these changes
Jan 27, 2025
cburroughs
added a commit
that referenced
this pull request
Jan 28, 2025
This is followup to #311 Per https://github.com/actions/upload-pages-artifact/releases/tag/v3.0.0 `actions/upload-pages-artifact@3` requires `actions/deploy-pages@v4`
cburroughs
added a commit
that referenced
this pull request
Jan 28, 2025
This is followup to #311 Per https://github.com/actions/upload-pages-artifact/releases/tag/v3.0.0 `actions/upload-pages-artifact@3` requires `actions/deploy-pages@v4`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last docs update failed with:
https://github.com/pantsbuild/pantsbuild.org/actions/runs/12934911051/job/36077004632
This is presumably from a transitive dependency from
deploy-pages@v2to the deprecated action.