Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tree): state root task multiproof metrics #14534

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(tree): state root task multiproof metrics #14534

wants to merge 6 commits into from

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Feb 17, 2025 •
edited
Loading

image

@shekhirin shekhirin added C-enhancement New feature or request A-observability Related to tracing, metrics, logs and other observability tools A-engine Related to the engine implementation labels Feb 17, 2025
@shekhirin shekhirin changed the title feat(tree): multiproof metrics feat(tree): state root task multiproof metrics Feb 17, 2025
@shekhirin shekhirin marked this pull request as ready for review February 17, 2025 14:58
Rjected
Rjected reviewed Feb 17, 2025
View reviewed changes
etc/grafana/dashboards/overview.json Outdated
"targets": [
{
"datasource": {
"type": "prometheus",
"uid": "${datasource}"
"uid": "${DS_PROMETHEUS}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to change these back to ${datasource}

@shekhirin shekhirin force-pushed the alexey/state-root-task-inflight-multiproof-metric branch from 1333c06 to 37569a1 Compare February 19, 2025 15:12
@shekhirin shekhirin enabled auto-merge February 19, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected left review comments

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A-engine Related to the engine implementation A-observability Related to tracing, metrics, logs and other observability tools C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @Rjected