feat(l2-withdrawals): Decompose ExecutionPayloadValidator::ensure_well_formed_payload
#14566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fork specific functions
emhane
added
C-debt
…d into fork specific functions
emhane
changed the title
ExecutionPayloadValidator::ensure_well_formed_payload
mattsse
reviewed
Feb 19, 2025
| is_cancun_active: bool, | ||
| ) -> Result<(), PayloadError> { | ||
| if is_cancun_active { | ||
| if !block_body.has_eip4844_transactions() { |
There was a problem hiding this comment.
this check is wrong I believe
There was a problem hiding this comment.
should the error variant be removed from alloy?
There was a problem hiding this comment.
I think so, i believe this was intended for the sidecar fields which we check seperately
mattsse
approved these changes
Feb 19, 2025
| is_cancun_active: bool, | ||
| ) -> Result<(), PayloadError> { | ||
| if is_cancun_active { | ||
| if !block_body.has_eip4844_transactions() { |
There was a problem hiding this comment.
I think so, i believe this was intended for the sidecar fields which we check seperately
loocapro
pushed a commit
to loocapro/reth
that referenced
this pull request
Feb 19, 2025
…ll_formed_payload` (paradigmxyz#14566)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-req for #14177
Moves the payload field checks into functions, grouped in modules based on hardfork. This provides building blocks for L2s to implement custom payload validation, for example OP would skip the Cancun validations on the transactions field, but would still check if cancun payload fields are present or not present.