fix: dereferenceable attribute on builtins #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
dani/fix-dereferenceable
branch
2 times, most recently
from
5b76f34 to
6f68e06
Compare
DaniPopes
force-pushed
the
dani/fix-dereferenceable
branch
from
6f68e06 to
50ed740
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dereferenceable(<n>)was passed to builtin params withn_inputs * 32, so something likeSELFBALANCEthat has more outputs that inputs (1 > 0) would haveptr dereferenceable(0).This basically means that we were telling LLVM that the pointer is never used :(