Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification on https protocol when computing the base url of an api call #117

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 16 additions & 18 deletions qualysapi/connector.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,26 +118,24 @@ def url_api_version(self, api_version):
""" Return base API url string for the QualysGuard api_version and server.

"""
# Set base url depending on API version.
if api_version == 1:
# QualysGuard API v1 url.
url = f"https://{self.server}/msp/"
elif api_version == 2:
# QualysGuard API v2 url.
url = f"https://{self.server}/"
elif api_version == "was":
# QualysGuard REST v3 API url (Portal API).
url = f"https://{self.server}/qps/rest/3.0/"
elif api_version == "am":
# QualysGuard REST v2 API url (Portal API).
url = f"https://{self.server}/qps/rest/2.0/"
elif api_version == "am2":
# QualysGuard REST v2 API url (Portal API).
url = f"https://{self.server}/qps/rest/2.0/"
else:
url = f"https://{self.server}" if "https://" not in self.server else self.server

paths = {
1: "/msp/", # QualysGuard API v1 url.
2: "/", # QualysGuard API v2 url.
"was": "/qps/rest/3.0/", # QualysGuard REST v3 API url (Portal API).
"am": "/qps/rest/2.0/", # QualysGuard REST v2 API url (Portal API).
"am2": "/qps/rest/2.0/", # QualysGuard REST v2 API url (Portal API).
}

computed_path = paths.get(api_version)

if computed_path is None:
raise Exception(f"Unknown QualysGuard API Version Number {api_version}")

logger.debug("Base url =\n%s", url)
return url
return url + computed_path


def format_http_method(self, api_version, api_call, data):
""" Return QualysGuard API http method, with POST preferred..
Expand Down