Create configmap if Fluentbit is enabled #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Lamirault <[email protected]>
nlamirault
changed the title
Signed-off-by: Nicolas Lamirault <[email protected]>
nirav-rafay
requested changes
Oct 14, 2024
| @@ -1,3 +1,4 @@ | |||
| {{- if .Values.deploy.filebeat.enable }} | |||
There was a problem hiding this comment.
@nlamirault filebeat is used to collect audit logs into the system via elasticsearch whereas Fluentbit is used to collect audit logs into the system via a database. Both cannot be used together, why are we trying to control fluentbit's configuration if filebeat is enabled ?
Can you elaborate on the problem and what are we trying to achieve here ?
There was a problem hiding this comment.
it was a typo. fixed.
If we set deploy.filebeat.enable: false, this configmap must not be deployed
nlamirault
changed the title
Signed-off-by: Nicolas Lamirault <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Only create configmap for FluentBit when
deploy.filebeat.enable: trueDoes the PR depend on any other PRs or Issues? If yes, please list them.
Checklist
I confirm, that I have...
CONTRIBUTING.mdCHANGELOG.mdhelm-docsto update docs for chart (if values.yaml file was changed)